Wrong page tracked when user comes back after checkout #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkloes
requested changes
Feb 15, 2019
| @@ -11,8 +11,6 @@ import { checkoutDidEnter$ } from '../streams/checkout'; | |||
| */ | |||
| export default function checkout(subscribe) { | |||
| subscribe(checkoutDidEnter$, ({ getState }) => { | |||
| setPWAVisibleState(false); | |||
There was a problem hiding this comment.
This change affects the pageview events, which are dispatched for users who where not logged in when they entered the checkout. For them the system will now track an additional pageview for the cart right after initiatedCheckout.
That happens because APP_EVENT_VIEW_DID_DISAPPEAR is triggered after the history.pop() which is called to remove the login page from the PWA history stack.
| const routeDidEnterForVisiblePwa$ = routeDidEnter$ | ||
| .withLatestFrom(appWillStart$.merge(pwaVisibility$)) | ||
| .filter(([, { action: { type } }]) => type === APP_WILL_START || type === PWA_DID_APPEAR) | ||
| .map(([routeDidEnter]) => routeDidEnter); |
There was a problem hiding this comment.
The startpage is now tracked twice when the app starts, since both actions are are dispatched in this situation.
alexbridge
force-pushed
the
PWA-1703-6.2
branch
from
5469cc1
to
bf80fcb
Compare
fkloes
approved these changes
Feb 15, 2019
Pull Request Test Coverage Report for Build 2027
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wrong page tracked when user comes back after checkout
Type of change
Please add an "x" into the option that is relevant: