-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored the Sliders to use the new react-id-swiper version #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t react-id-swiper in newest version. Also refactored all usages of the swiper.
Pull Request Test Coverage Report for Build 2186
💛 - Coveralls |
fkloes
previously requested changes
Mar 21, 2019
themes/theme-gmd/pages/Product/components/ImageSlider/index.jsx
Outdated
Show resolved
Hide resolved
themes/theme-gmd/pages/ProductGallery/components/ZoomPanSlider/index.jsx
Outdated
Show resolved
Hide resolved
Things that I noticed while testing:
|
SG-Noxoreos
dismissed
fkloes’s stale review
March 28, 2019 11:15
Won't re-review. Taken over by @SG-Noxoreos
SG-Noxoreos
approved these changes
Mar 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tested and no more issues found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the react-id-swiper to the newest version and refactored all sliders to be compatible with the new API. This caused react and react-dom to be updated to the newest versions to provide the new hooks API which is needed for react-id-swiper.
Type of change
Please add an "x" into the option that is relevant:
How to test it
Please describe here any specialty that the tester should be aware of.