Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a slider issue with swiping through zoomed slides #665

Merged
merged 2 commits into from
May 22, 2019

Conversation

fkloes
Copy link
Collaborator

@fkloes fkloes commented May 21, 2019

Description

This ticket is about to fix a slider issue with swiping though zoomed slides. Now swiped out slides should reset to the initial zoom state.

Type of change

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • Enhancement 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Internal 🏠 Only relates to internal processes.

How to test it

  • open the gallery page of a product with multiple images
  • zoom an image via pinch or double tap
  • swipe to the next image and back

The previously zoomed image should have the original state.

- zoomed swipes are now reset when swiped out of the viewport
- added subscription to fetch the product gallery when the gallery page was opened directly
@fkloes fkloes added the bug Something isn't working label May 21, 2019
@fkloes fkloes self-assigned this May 21, 2019
@devbucket devbucket merged commit 4fc3d02 into v6.5.1 May 22, 2019
@devbucket devbucket deleted the PWA-1932-zoom-slider-issues branch May 22, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants