Show placeholder or featured media on product details page #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct page is loaded
alexbridge
force-pushed
the
PWA-2121-pdp-image-670
branch
from
2893a8e
to
3b8da29
Compare
…better describe what it actually does.
…word "Component".
… to `baseProduct` avoid confusion and improve clarity about what data it actually gets. Also renamed the state update method in `MediaImage` component to even better describe what it actually does.
SG-Noxoreos
approved these changes
Jul 8, 2019
SG-Noxoreos
suggested changes
Jul 8, 2019
There was a problem hiding this comment.
- I didn't see any issues with the code directly. Some testing revealed buggy behavior. When changing characteristic selections forth and back, the image, which was shown before is blank, when selecting a variant that was selected previously. This seems to happen only on the first characteristic.
EDIT: Seems like this issue is not directly related to the changes done here. - Also, switching to a placeholder when changing characteristics appears like a visual bug, because it tends to show the placeholder for less than a second, making the transition appear to stutter (looks like three short flickers in a row, when images are not available, yet: it removes the image, shows the placeholder, removes the placeholder and shows the new image).
…ct page is loaded
…oductMedia is available
…uredImage component
…age-670 # Conflicts: # libraries/engage/product/index.js
alexbridge
commented
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show placeholder / featured media on product details page when product media is not available
Type of change
Please add an "x" into the option that is relevant: