-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show placeholder or featured media on product details page #756
Conversation
…ct page is loaded
2893a8e
to
3b8da29
Compare
…better describe what it actually does.
…word "Component".
… to `baseProduct` avoid confusion and improve clarity about what data it actually gets. Also renamed the state update method in `MediaImage` component to even better describe what it actually does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I didn't see any issues with the code directly. Some testing revealed buggy behavior. When changing characteristic selections forth and back, the image, which was shown before is blank, when selecting a variant that was selected previously. This seems to happen only on the first characteristic.
EDIT: Seems like this issue is not directly related to the changes done here. - Also, switching to a placeholder when changing characteristics appears like a visual bug, because it tends to show the placeholder for less than a second, making the transition appear to stutter (looks like three short flickers in a row, when images are not available, yet: it removes the image, shows the placeholder, removes the placeholder and shows the new image).
…ct page is loaded
…oductMedia is available
…uredImage component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are needed
…age-670 # Conflicts: # libraries/engage/product/index.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOs FeatureImage
height is ~30% of media slider
Description
Show placeholder / featured media on product details page when product media is not available
Type of change
Please add an "x" into the option that is relevant: