Decoupled swatch content into a separate component and introduced a VariantSwatch widget component to be rendered in the PDP #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SG-Noxoreos
reviewed
Jul 17, 2019
SG-Noxoreos
reviewed
Jul 17, 2019
themes/theme-gmd/pages/Product/components/Characteristics/Swatch/index.jsx
Outdated
Show resolved
Hide resolved
devbucket
suggested changes
Jul 17, 2019
devbucket
approved these changes
Jul 18, 2019
SG-Noxoreos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Swatch styling use different identifier in variant selection
Type of change
Please add an "x" into the option that is relevant: