Fixed onClick handers for custom SearchSuggestionItem components within the iOS 11 theme #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- extensions can now replace the search suggestion items with working click handlers
fkloes
changed the title
devbucket
approved these changes
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ticket fixes an issue that prevented fully working click handlers of extension replacements for SearchSuggestionItem components within the iOS 11 theme. It also should fix React errors about state updates within unmounted components when a search is initiated by pressing the "Enter" button.
Type of change
How to test it
Attach an extension like the one from this issue report. Clicking a search suggestion item should now initiate a search.