Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved View and ViewContext to engage package #907

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

alexbridge
Copy link
Contributor

@alexbridge alexbridge commented Jan 29, 2020

Description

Moved <View /> and <ViewContext /> to engage package. Changed themes GMD and iOS11 to use components from engage package. Expose engage component view as a part of theme api.

Type of change

Please add an "x" into the option that is relevant:

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • Enhancement 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Internal 🏠 Only relates to internal processes.

@alexbridge alexbridge added the enhancement New feature or request label Jan 29, 2020
@alexbridge alexbridge self-assigned this Jan 29, 2020
@devbucket devbucket changed the title Move View component and view context to Engage package Moved View and ViewContext to engage package Jan 30, 2020
@devbucket devbucket merged commit 477453c into v6.12.0 Jan 30, 2020
@devbucket devbucket deleted the PWA-2133-view-component branch January 30, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants