Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12][IMP] add test to create shopinvader category from category #421

Closed
wants to merge 1 commit into from
Closed

[12][IMP] add test to create shopinvader category from category #421

wants to merge 1 commit into from

Conversation

lmignon
Copy link
Collaborator

@lmignon lmignon commented Sep 21, 2019 •
edited
Loading

This PR is a forward port of the tests into #419 to see if the problem is also present into 12.0

@lmignon lmignon added the 12.0 label Sep 21, 2019
@lmignon lmignon added this to the 12.0 milestone Sep 21, 2019
@sebastienbeau
Copy link
Contributor

I am going to rebase it

@sebastienbeau
Copy link
Contributor

I just create a new PR here rebased : #927
Let's see if still red, if it's the case I will fix it

@sebastienbeau sebastienbeau self-assigned this Mar 26, 2021
@PierrickBrun PierrickBrun self-requested a review March 26, 2021 09:24
PierrickBrun
PierrickBrun requested changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@PierrickBrun PierrickBrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by error, the PR has been re done by Sebastien

@sebastienbeau
Copy link
Contributor

I close this one.
The code in now fixed on V12 but I merge the test to avoid getting back this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierrickBrun PierrickBrun PierrickBrun requested changes

Assignees

@sebastienbeau sebastienbeau

Labels
12.0
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lmignon @sebastienbeau @PierrickBrun @bguillot