Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] 14.0 product_variant_selector #918

Closed
wants to merge 2 commits into from
Closed

[MIG] 14.0 product_variant_selector #918

wants to merge 2 commits into from

Conversation

PierrickBrun
Copy link
Contributor

No description provided.

@sbidoul sbidoul added the 14.0 label Mar 23, 2021
@rousseldenis rousseldenis mentioned this pull request Mar 26, 2021
Closed
49 tasks
@rousseldenis rousseldenis added this to the 14.0 milestone Mar 26, 2021
@kevinkhao
Copy link
Contributor

LGTM but duplicate of
#865

@kevinkhao kevinkhao mentioned this pull request Mar 26, 2021
Merged
@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Contributor

@PierrickBrun Do you mind if we merge the other one ?

@PierrickBrun
Copy link
Contributor Author

@rousseldenis Not at all

@hparfr hparfr deleted the 14.0-mig-product_variant_selector branch March 26, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourad-ehm mourad-ehm mourad-ehm approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@kevinkhao kevinkhao kevinkhao approved these changes

Assignees
No one assigned
Labels
14.0 approved duplicate migration needs review ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
6 participants
@PierrickBrun @kevinkhao @shopinvader-git-bot @rousseldenis @mourad-ehm @sbidoul