Category now has second description attribute that is displayed on the product list page above the product list #8
Conversation
Miroslav-Stopka
commented
Jul 31, 2018
•
Miroslav-Stopka
commented
| Q | A |
|---|---|
| Description, reason for the PR | Category: added second description attribute |
| New feature | Yes |
| BC breaks | No |
| Fixes issues | #5 |
| Standards and tests pass | Yes/No (waiting for split) |
| Have you read and signed our License Agreement for contributions? | Yes |
Miroslav-Stopka
force-pushed
the
msa-category-second-description
branch
2 times, most recently
from
a62840b
to
983f9df
Compare
Miroslav-Stopka
changed the title
boris-brtan
changed the title
| @@ -0,0 +1,77 @@ | |||
| <?php | |||
| /** | |||
There was a problem hiding this comment.
automatically generated docblocks of PHPstorm are useless
| use Shopsys\FrameworkBundle\Form\Admin\Category\CategoryFormType; | ||
| use Shopsys\FrameworkBundle\Form\FormRenderingConfigurationExtension; | ||
| use Shopsys\FrameworkBundle\Form\GroupType; | ||
|
|
There was a problem hiding this comment.
hmm, wonder whether this blank line between use statements passes the standards
There was a problem hiding this comment.
You are right, I have removed this empty line
| @@ -37,3 +37,11 @@ services: | |||
| - { name: doctrine.event_subscriber, priority: -10 } | |||
|
|
|||
| League\Flysystem\FilesystemInterface: '@main_filesystem' | |||
|
|
|||
| Shopsys\FrameworkBundle\Model\Category\CategoryFactoryInterface: '@Shopsys\ShopBundle\Model\Category\CategoryFactory' | |||
There was a problem hiding this comment.
Please, consider to implement it the same way as Shopsys\FrameworkBundle\Model\Product\ProductFactoryInterface:
alias: Shopsys\ShopBundle\Model\Product\ProductFactory
since it is already merged into master
There was a problem hiding this comment.
Considered and applied
| Shopsys\FrameworkBundle\Model\Product\Product: Shopsys\ShopBundle\Model\Product\Product | ||
| Shopsys\FrameworkBundle\Model\Category\Category: Shopsys\ShopBundle\Model\Category\Category | ||
| Shopsys\FrameworkBundle\Model\Category\CategoryDomain: Shopsys\ShopBundle\Model\Category\CategoryDomain |
There was a problem hiding this comment.
sorry but this has got problem with missing blank line at the end
Miroslav-Stopka
force-pushed
the
msa-category-second-description
branch
from
983f9df
to
adaff04
Compare
|
Hi @boris-brtan thank you for this review :) Please inform me about tests results. |
|
|
||
| ### Changed | ||
| - [#1 - Basic changes in docs, readme etc. after copying from project-base](https://github.com/shopsys/demoshop/pull/1) : [@LukasHeinz] | ||
|
|
||
| ### Fixed |
There was a problem hiding this comment.
There should be no "Fixed" entry to changelog, I see entry in "Added" part and it is enough, isn't it?
There was a problem hiding this comment.
I decided to add a note to the fixed section because of this commit 03a30c0
Miroslav-Stopka
force-pushed
the
msa-category-second-description
branch
from
13a85fe
to
03a30c0
Compare
…of those from framework
- PHPUnit 7.2 and Codeception 2.4 are incompatible, see Codeception/Codeception#5092
