Skip to content

Commit

Permalink
[shopsys] graphql query is not in transaction (#2516)
Browse files Browse the repository at this point in the history
Co-authored-by: Milan Staňo <milan.stano@shopsys.com>
  • Loading branch information
stanoMilan and msshopsys committed Sep 15, 2023
1 parent fd45f8c commit 7690046
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 39 deletions.
7 changes: 0 additions & 7 deletions app/config/services.yaml
Expand Up @@ -656,13 +656,6 @@ services:
tags:
- { name: shopsys.friendly_url_provider }

Shopsys\FrameworkBundle\Component\HttpFoundation\TransactionalMasterRequestListener:
class: App\Component\HttpFoundation\TransactionalMasterRequestListener
tags:
- { name: kernel.event_listener, event: kernel.request, method: onKernelRequest }
- { name: kernel.event_listener, event: kernel.response, method: onKernelResponse }
- { name: kernel.event_listener, event: kernel.exception, method: onKernelException }

App\Component\Image\ImageLocator:
arguments: ['%shopsys.image_dir%']

Expand Down

This file was deleted.

4 changes: 2 additions & 2 deletions app/src/Model/CategorySeo/ReadyCategorySeoMixFacade.php
Expand Up @@ -4,7 +4,6 @@

namespace App\Model\CategorySeo;

use App\Component\HttpFoundation\TransactionalMasterRequestListener;
use App\Component\Router\FriendlyUrl\FriendlyUrlFacade;
use App\FrontendApi\Model\Flag\FlagFacade;
use App\FrontendApi\Model\Parameter\ParameterFacade;
Expand All @@ -17,6 +16,7 @@
use Doctrine\ORM\EntityManagerInterface;
use Shopsys\FrameworkBundle\Component\Domain\Config\DomainConfig;
use Shopsys\FrameworkBundle\Component\Domain\Domain;
use Shopsys\FrameworkBundle\Component\HttpFoundation\TransactionalMasterRequestListener;
use Shopsys\FrameworkBundle\Component\Router\FriendlyUrl\UrlListData;
use Shopsys\FrameworkBundle\Model\Product\Parameter\Exception\ParameterNotFoundException;
use Shopsys\FrameworkBundle\Model\Product\Parameter\Parameter;
Expand Down Expand Up @@ -78,7 +78,7 @@ public function createOrEdit(
try {
$this->validateReadyCategoryMixFriendlyUrls($readyCategorySeoMix);
} catch (ReadyCategorySeoMixUrlsContainBadDomainUrlException | ReadyCategorySeoMixUrlsDoNotContainUrlForCorrectDomainException $e) {
TransactionalMasterRequestListener::setTransactionHasBeenRollbacked();
TransactionalMasterRequestListener::setTransactionManuallyRollbacked();
$this->em->rollback();

throw $e;
Expand Down

0 comments on commit 7690046

Please sign in to comment.