Skip to content

Commit

Permalink
fixup! added upgrade instruction for PHPStan level 4
Browse files Browse the repository at this point in the history
  • Loading branch information
vitek-rostislav committed Sep 5, 2019
1 parent 789381e commit 189f9db
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions docs/upgrade/UPGRADE-v8.1.0-dev.md
Expand Up @@ -135,14 +135,14 @@ There you can find links to upgrade notes for other versions too.

<import file="${path.framework}/build.xml"/>
```
- Increase your PHPStan level to 4 in your `build.xml` ([#1040](https://github.com/shopsys/shopsys/pull/1040))
- increase your PHPStan level to 4 in your `build.xml` ([#1040](https://github.com/shopsys/shopsys/pull/1040))
```diff
- <property name="phpstan.level" value="1"/>
+ <property name="phpstan.level" value="4"/>
```
- A lot of the possible issues should be already resolved if you followed the previous instruction and ran the `php phing annotations-fix` phing command.
- Some of the issues related to class extension need to be addressed manually nevertheless (see the ["Framework extensibility" article](../introduction/framework-extensibility.md#problem-3)) for more information.
- You need to resolve all the other reported problems (any of them can be ignored in your `phpstan.neon`). You can find inspiration in [#1040](https://github.com/shopsys/shopsys/pull/1040).
- a lot of the possible issues should be already resolved if you followed the previous instruction and ran the `php phing annotations-fix` phing command
- some of the issues related to class extension need to be addressed manually nevertheless (see the ["Framework extensibility" article](../introduction/framework-extensibility.md#problem-3)) for more information
- you need to resolve all the other reported problems (any of them can be ignored in your `phpstan.neon`). You can find inspiration in [#1040](https://github.com/shopsys/shopsys/pull/1040)
### Database migrations
- run database migrations so products will use a DateTime type for columns for "Selling start date" (selling_from) and "Selling end date" (selling_to) ([#1343](https://github.com/shopsys/shopsys/pull/1343))
- please check [`Version20190823110846`](https://github.com/shopsys/shopsys/blob/master/packages/framework/src/Migrations/Version20190823110846.php)
Expand Down

0 comments on commit 189f9db

Please sign in to comment.