-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shopsys] composer.json: revert BC breaking change of snc/redis-bundle dependency #1013
Conversation
maybe we could compare version of php extension for redis on travis and in our Dockerfile
phpredis/phpredis/issues/1333 |
@boris-brtan You're right about the PECL extension version. There was 3.1.4 installed on Travis, we need 4.1.1. See https://travis-ci.org/shopsys/shopsys/builds/530758153 for details. |
a796564
to
1e4c640
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI,
thx for the fixes, i have just some questions and suggestions.
Maybe some additional information could be added into PR description.
i just noticed another thing that in README.md there is not the same link for OK build to travis at it is for packages
|
@boris-brtan Yes, there is a different alt text and it's not a link to the Travis page, but to the image itself. Could you create a PR to fix that please? |
- this reverts a part of the commit c66339d
- the version preinstalled on Travis was 3.1.4 which was incompatible with the snc/redis-bundle >= 2.1.8
1e4c640
to
f390acb
Compare
snc/redis-bundle
package were changed which breaks backward compatibility. Even though we don't define BC in terms of dependencies precisely (see #872), you cannot useshopsys/framework
in versiondev-master
using theshopsys/project-base
in the7.0.0
version as a base repository without further changes (see below).When using
shopsys/project-base
in version7.0.0
and replacing allshopsys/*
dependencies todev-master
(current master is on b3128c4) version, following error is thrown duringcomposer install
:The modification of
composer.json
was originally done in #978 so that Travis build succeeds (not sure about the exact reason). This goal of this PR is to pass on Travis while still being backward-compatible withshopsys/project-base
in7.0.0
.