Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shopsys] composer.json: revert BC breaking change of snc/redis-bundle dependency #1013

Merged
merged 2 commits into from
May 13, 2019

Conversation

PetrHeinz
Copy link
Contributor

@PetrHeinz PetrHeinz commented May 10, 2019

Q A
Description, reason for the PR In #978 the supported versions of snc/redis-bundle package were changed which breaks backward compatibility. Even though we don't define BC in terms of dependencies precisely (see #872), you cannot use shopsys/framework in version dev-master using the shopsys/project-base in the 7.0.0 version as a base repository without further changes (see below).
New feature No
BC breaks No
Fixes issues ...
Standards and tests pass Yes
Have you read and signed our License Agreement for contributions? Yes

When using shopsys/project-base in version 7.0.0 and replacing all shopsys/* dependencies to dev-master (current master is on b3128c4) version, following error is thrown during composer install:

Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - shopsys/framework dev-master requires snc/redis-bundle ^2.1.7 -> satisfiable by snc/redis-bundle[2.1.8, 2.1.9].
    - snc/redis-bundle 2.1.8 conflicts with shopsys/framework[dev-master].
    - snc/redis-bundle 2.1.9 conflicts with shopsys/framework[dev-master].
    - Installation request for shopsys/framework dev-master -> satisfiable by shopsys/framework[dev-master].

The modification of composer.json was originally done in #978 so that Travis build succeeds (not sure about the exact reason). This goal of this PR is to pass on Travis while still being backward-compatible with shopsys/project-base in 7.0.0.

@boris-brtan
Copy link
Contributor

boris-brtan commented May 10, 2019

maybe we could compare version of php extension for redis on travis and in our Dockerfile

RUN pecl install redis-4.1.1 && \
    docker-php-ext-enable redis

phpredis/phpredis/issues/1333
Kdyby/Redis#80
snc/SncRedisBundle#487 [2.1.8 lazyload for phpredis]

@PetrHeinz
Copy link
Contributor Author

@boris-brtan You're right about the PECL extension version. There was 3.1.4 installed on Travis, we need 4.1.1. See https://travis-ci.org/shopsys/shopsys/builds/530758153 for details.

Copy link
Contributor

@boris-brtan boris-brtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI,
thx for the fixes, i have just some questions and suggestions.
Maybe some additional information could be added into PR description.

.travis.yml Show resolved Hide resolved
project-base/composer.json Show resolved Hide resolved
@boris-brtan
Copy link
Contributor

boris-brtan commented May 10, 2019

i just noticed another thing that in README.md there is not the same link for OK build to travis at it is for packages

[![Build Status](https://travis-ci.org/shopsys/migrations.svg?branch=master)](https://travis-ci.org/shopsys/migrations)
![travis-badge](https://travis-ci.org/shopsys/shopsys.svg?branch=master)

@PetrHeinz
Copy link
Contributor Author

@boris-brtan Yes, there is a different alt text and it's not a link to the Travis page, but to the image itself. Could you create a PR to fix that please?

- the version preinstalled on Travis was 3.1.4 which was incompatible with the snc/redis-bundle >= 2.1.8
@PetrHeinz PetrHeinz merged commit 75a8865 into master May 13, 2019
@PetrHeinz PetrHeinz deleted the ph-dependency-bc-fix branch May 13, 2019 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants