Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[framework] private -> protected in Shopsys\FrameworkBundle\Twig namespace #1114

Merged
merged 1 commit into from Jun 17, 2019
Merged

[framework] private -> protected in Shopsys\FrameworkBundle\Twig namespace #1114

merged 1 commit into from Jun 17, 2019

Conversation

vitek-rostislav
Copy link
Contributor

  • done to allow extensibility by inheritance
  • watched by Shopsys\CodingStandards\CsFixer\ForbiddenPrivateVisibilityFixer
Q A
Description, reason for the PR Twig extensions are not extendable easily
New feature No
BC breaks No
Fixes issues fixes #1098
Have you read and signed our License Agreement for contributions? Yes

@vitek-rostislav
all the properties and methods in Shopsys\FrameworkBundle\Twig namespace
470d6df 
has now protected instead of private visibility

- done to allow extensibility by inheritance
- watched by Shopsys\CodingStandards\CsFixer\ForbiddenPrivateVisibilityFixer
boris-brtan
boris-brtan approved these changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@boris-brtan boris-brtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICEeeee

LukasHeinz
LukasHeinz approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@LukasHeinz LukasHeinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job

@vitek-rostislav vitek-rostislav merged commit 92fdc4d into master Jun 17, 2019
@vitek-rostislav vitek-rostislav deleted the rv-twig-protected branch June 17, 2019 05:52
@vitek-rostislav vitek-rostislav mentioned this pull request Jul 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHeinz LukasHeinz LukasHeinz approved these changes

@boris-brtan boris-brtan boris-brtan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Override/extend twig extensions is not possible
3 participants
@vitek-rostislav @LukasHeinz @boris-brtan