Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shopsys] fix issues with QueryBuilderExtender's method AddOrExtendJoin #1391

Merged
merged 6 commits into from Mar 10, 2020
Merged

[shopsys] fix issues with QueryBuilderExtender's method AddOrExtendJoin #1391

merged 6 commits into from Mar 10, 2020

Conversation

pk16011990
Copy link
Member

@pk16011990 pk16011990 commented Sep 10, 2019 •
edited by DavidOstrozlik

Q A
Description, reason for the PR there are problems with QueryBuilderExtender's method AddOrExtendJoin
New feature No
BC breaks No
Fixes issues closes #997
Have you read and signed our License Agreement for contributions? Yes
  • fix AddOrExtendJoin then creating first join
  • fix AddOrExtendJoin when you try to extend framework's class with extended class
  • add test for first issue
  • add unit test for second issue
  • add functional test for second issue

@DavidOstrozlik DavidOstrozlik changed the title add QueryBuilderExtenderTest with failing first join test [shopsys] fix issues with QueryBuilderExtender's method AddOrExtendJoin Sep 10, 2019
PetrHeinz
PetrHeinz suggested changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@PetrHeinz PetrHeinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! And thanks for reporting #1417 👍

Apart from some issues with annotations below it's fine. Because it's a backward-compatible bugfix it needs to be rebased and retargeted to 7.3 before merging.

packages/framework/src/Component/Doctrine/QueryBuilderExtender.php Outdated Show resolved Hide resolved
packages/framework/src/Component/Doctrine/QueryBuilderExtender.php Outdated Show resolved Hide resolved
project-base/tests/ShopBundle/Functional/Component/Doctrine/QueryBuilderExtenderTest.php Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Jan 16, 2020

This issue has been automatically marked as stale because there was no activity within the last 4 months (and it is quite a long time). It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale This issue have not been touched for some time and if it doesn't change, it will be closed soon. label Jan 16, 2020
@s3tezsky s3tezsky removed the Stale This issue have not been touched for some time and if it doesn't change, it will be closed soon. label Jan 16, 2020
@pk16011990
Copy link
Member Author

Hi,

when can I expect reaction/merge?

@s3tezsky s3tezsky force-pushed the do-pk-query-builder-extender-fixes branch from 6ab5f79 to df56122 Compare March 2, 2020 11:33
@s3tezsky s3tezsky changed the base branch from master to 7.3 March 2, 2020 11:33
@s3tezsky s3tezsky force-pushed the do-pk-query-builder-extender-fixes branch 2 times, most recently from e62567c to a18223c Compare March 2, 2020 14:01
@s3tezsky s3tezsky dismissed their stale review March 3, 2020 08:11

Dismissing review

@s3tezsky s3tezsky mentioned this pull request Mar 8, 2020
Closed
@TomasLudvik TomasLudvik force-pushed the do-pk-query-builder-extender-fixes branch from 67a6663 to cdb86f0 Compare March 10, 2020 08:44
@TomasLudvik TomasLudvik merged commit 12b5af8 into 7.3 Mar 10, 2020
@TomasLudvik TomasLudvik deleted the do-pk-query-builder-extender-fixes branch March 10, 2020 08:45
@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PetrHeinz PetrHeinz PetrHeinz requested changes

@sslt sslt sslt approved these changes

@s3tezsky s3tezsky s3tezsky left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ProductFilterRepository - error in queryBuilder (addOrExtendJoin)
6 participants
@pk16011990 @PetrHeinz @sslt @s3tezsky @TomasLudvik @DavidOstrozlik