[shopsys] Eased installation of project with different domains and locales settings #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitek-rostislav
force-pushed
the
tl-rv-datafixtures-refactoring
branch
5 times, most recently
from
98c6f7b
to
5bedf98
Compare
s3tezsky
reviewed
Sep 30, 2019
packages/backend-api/install/tests/ShopBundle/Smoke/BackendApiCreateProductTest.php
Outdated
Show resolved
Hide resolved
packages/backend-api/install/tests/ShopBundle/Smoke/BackendApiUpdateProductTest.php
Show resolved
Hide resolved
project-base/src/Shopsys/ShopBundle/DataFixtures/Demo/ArticleDataFixture.php
Outdated
Show resolved
Hide resolved
project-base/src/Shopsys/ShopBundle/DataFixtures/Demo/AvailabilityDataFixture.php
Show resolved
Hide resolved
project-base/src/Shopsys/ShopBundle/DataFixtures/Demo/BestsellingProductDataFixture.php
Outdated
Show resolved
Hide resolved
project-base/src/Shopsys/ShopBundle/DataFixtures/Demo/ProductDataFixture.php
Show resolved
Hide resolved
project-base/src/Shopsys/ShopBundle/DataFixtures/Demo/UserDataFixture.php
Outdated
Show resolved
Hide resolved
project-base/src/Shopsys/ShopBundle/DataFixtures/Demo/UserDataFixture.php
Show resolved
Hide resolved
...base/tests/ShopBundle/Functional/Model/Product/ProductOnCurrentDomainFacadeCountDataTest.php
Show resolved
Hide resolved
project-base/tests/ShopBundle/Functional/Model/Product/ProductOnCurrentDomainFacadeTest.php
Show resolved
Hide resolved
vitek-rostislav
force-pushed
the
tl-rv-datafixtures-refactoring
branch
from
a598881
to
d39703d
Compare
TomasLudvik
force-pushed
the
tl-rv-datafixtures-refactoring
branch
from
181db09
to
c857eef
Compare
vitek-rostislav
force-pushed
the
tl-rv-datafixtures-refactoring
branch
from
3583ad9
to
0a6bcf4
Compare
s3tezsky
reviewed
Oct 1, 2019
...base/tests/ShopBundle/Functional/Model/Product/ProductOnCurrentDomainFacadeCountDataTest.php
Outdated
Show resolved
Hide resolved
TomasLudvik
force-pushed
the
tl-rv-datafixtures-refactoring
branch
2 times, most recently
from
f5bed87
to
46bebdf
Compare
vitek-rostislav
force-pushed
the
tl-rv-datafixtures-refactoring
branch
from
b36ea6a
to
6a933e3
Compare
TomasLudvik
force-pushed
the
tl-rv-datafixtures-refactoring
branch
from
6a933e3
to
0b68383
Compare
vitek-rostislav
force-pushed
the
tl-rv-datafixtures-refactoring
branch
4 times, most recently
from
cfc83b9
to
6d18aec
Compare
s3tezsky
reviewed
Oct 2, 2019
project-base/src/Shopsys/ShopBundle/DataFixtures/Demo/OrderStatusDataFixture.php
Outdated
Show resolved
Hide resolved
s3tezsky
reviewed
Oct 2, 2019
project-base/tests/ShopBundle/Test/Codeception/Helper/LocalizationHelper.php
Outdated
Show resolved
Hide resolved
s3tezsky
reviewed
Oct 2, 2019
...base/tests/ShopBundle/Functional/Model/Product/ProductOnCurrentDomainFacadeCountDataTest.php
Show resolved
Hide resolved
vitek-rostislav
changed the title
DavidOstrozlik
suggested changes
Oct 3, 2019
project-base/tests/ShopBundle/Acceptance/acceptance/CartCest.php
Outdated
Show resolved
Hide resolved
project-base/tests/ShopBundle/Acceptance/acceptance/PageObject/Front/CartBoxPage.php
Outdated
Show resolved
Hide resolved
project-base/tests/ShopBundle/Smoke/Http/RouteConfigCustomization.php
Outdated
Show resolved
Hide resolved
project-base/tests/ShopBundle/Test/ParameterTransactionFunctionalTestCase.php
Outdated
Show resolved
Hide resolved
vitek-rostislav
force-pushed
the
tl-rv-datafixtures-refactoring
branch
from
dbda397
to
f4e4052
Compare
TomasLudvik
force-pushed
the
tl-rv-datafixtures-refactoring
branch
from
f4e4052
to
35ac52a
Compare
vitek-rostislav
force-pushed
the
tl-rv-datafixtures-refactoring
branch
2 times, most recently
from
78b33c5
to
adb684f
Compare
|
Hi guys, |
vitek-rostislav
force-pushed
the
tl-rv-datafixtures-refactoring
branch
from
aa30cd9
to
06eb181
Compare
…ings - as a result, there is no need for fixing this test when a project has a different domains and locales settings
…ings - as a result, there is no need for fixing this test when a project has a different domains and locales settings
- i.e. there is no need to fix the tests when different locales for 1st domain and/or administration are used - proper tranlsations and formatting are used thanks to the new LocalizationHelper - some translation messages in controllers (Paymnet, Product, Transport, Vat) rewritten to proper usage of translation parameters so it is possible to use the translation outside Twig - creation of CurrencyFormatter extracted from PriceExtension to new CurrencyFormatterFactory
…g are run only when the first domain has English locale
…mically loaded in order to load right id for current locale
… asserting a particular product is in the pagination result anymore - the results are ordered by product name so when using a different locale then "en", the particular product might not be on the first page
…with different locale than english - when first domain is for example in czech language than order of products might be different
…locale than english - when first domain is for example in czech language than results of search will be different
- testParameterFilterChoicesFromCategory does no longer require strict order of parameters and its values - ParameterValueIds are now loaded by its translations
- other tests test localization on domains so this is redundant
…not provided - when in admin, admin locale must be used (it can be different from the first domain locale) - LocalizationListener:isAdminRequest() protected method exracted to AdministrationFacade:isInAdmin() public method
…rder to make this test currency independent - if we want to assert particular prices in tests, we need to have particular prices in the order (now the prices are loaded dynamically in data fixtures based on the domain currency)
…he test is now currency independent - PriceConverter is used for the prices in the filter
- PriceConverter is used for the prices in the filter
- PriceConverter is used for the values in price filter
…TestCase and searchPriceTestCase are now currency independent - PriceConverter is used
- PriceConverter is used
- this commit addresses only the files that were modified in this PR - for proper solution in the whole codebase, there is a separate issue - #1453
TomasLudvik
force-pushed
the
tl-rv-datafixtures-refactoring
branch
from
d992940
to
c70efeb
Compare
TomasLudvik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, all classes with multidomain data fixtures (i.e.
Multidomain*DataFixture) are removed and the multi-attributes are defined in regular data fixture classes using the translator. As a part of this modification, we changed the behavior of multidomain data fixtures a little bit - now the data are different on the 2nd domain only (eg. czech locale, different currency, distinct set of customers, category tree, top products settings, ...), for the 3rd and all the other domains are used data from the 1st domain. - It makes much more sense this way - the first domain has been also used as a template for copying multidomain data inDomainDataCreator.In order to easily implement the translator feature in data fixtures, we also removed the CSV files for products and customers data.
We have also rewritten all the tests that were tight to default domains settings so that they are now resistant against the changes in domains and locales settings (we are using domain service to access 1st domain locale instead of hardcoding "en" locale, and we are using translator where needed). We even rewritten the tests for filtering that were using specific parameter values translations IDs as these can change when a different locale is used so we are now accessing the translated values using
getParameterValueByValueTextAndLocalemethod.We were not able to rewrite all the tests this way (eg. functional tests for searching a particular phrase in elasticsearch depend heavily on the locale setting) - such tests are now skipped if the settings for the first domain are changed.
To make the data fixtures and tests more resistant against changes of default currencies on domains, we introduced
PriceConverterthat is used in tests and data fixtures everywhere where specific prices were used.We addressed even acceptance tests - there is new
LocalizationHelperthat uses the translator to get the proper translations, and enables the tester to access localized routes. There is yet another new helper -NumberFormatHelper- that is able to format numbers in the proper locale and with a proper currency symbol.In acceptance tests, there is still a need for changes when a default currency is changed - there is no way how to easily convert total prices in cart or total prices of an order (we can not just convert the total prices because of the price calculation), however, at least filtering acceptance test is resistant against the currency changes as it is possible to convert the values in price filter using
PriceConverter.project-base. Changes in theframeworkpackage are done backward-compatible