Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[project-base] CartCest now uses correct translations #1582

Merged
merged 1 commit into from Jul 2, 2020
Merged

[project-base] CartCest now uses correct translations #1582

merged 1 commit into from Jul 2, 2020

Conversation

TomasLudvik
Copy link
Member

Q A
Description, reason for the PR In CartCest were used wrong translations and that cause problems with different language on first domain. This is now fixed.
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

@grossmannmartin
Copy link
Member

Hi, I rebased this pull request to the master branch as now the development version of 9.0.x release is on the master branch.

@grossmannmartin grossmannmartin changed the base branch from 9.0 to master January 27, 2020 20:12
@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell B 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sslt sslt added this to the SSFW 9.0.1 milestone Jul 1, 2020
@TomasLudvik TomasLudvik changed the base branch from master to 9.0 July 1, 2020 13:09
@sslt sslt added the Status: in implementation Resolving of this issue is currently in progress label Jul 1, 2020
@sonarcloud
Copy link

sonarcloud bot commented Jul 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@s3tezsky s3tezsky merged commit 66bf0f0 into 9.0 Jul 2, 2020
@s3tezsky s3tezsky deleted the tl-fix-cart branch July 2, 2020 09:53
@sslt sslt removed the Status: in implementation Resolving of this issue is currently in progress label Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sslt sslt sslt approved these changes

@s3tezsky s3tezsky s3tezsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
SSFW 9.0.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TomasLudvik @grossmannmartin @sslt @s3tezsky