Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[framework] encapsulation of AdditionalImageData #1934

Merged
merged 1 commit into from Apr 26, 2023
Merged

[framework] encapsulation of AdditionalImageData #1934

merged 1 commit into from Apr 26, 2023

Conversation

pk16011990
Copy link
Member

Q A
Description, reason for the PR immutable objects are more maintainable, datatypes are validated...
New feature No
BC breaks Yes
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

@sonarcloud
Copy link

sonarcloud bot commented Jul 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sslt sslt added this to the SSFW 10.0.0 milestone Jul 17, 2020
@TomasLudvik TomasLudvik changed the title encapsulation of AdditionalImageData [framework] encapsulation of AdditionalImageData Jul 17, 2020
@TomasLudvik TomasLudvik added the DX & Refactoring Requests for DX improvements and refactorings label Jul 27, 2020
@stale
Copy link

stale bot commented Dec 6, 2020

This issue has been automatically marked as stale because there was no activity within the last 4 months (and it is quite a long time). It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale This issue have not been touched for some time and if it doesn't change, it will be closed soon. label Dec 6, 2020
@henzigo henzigo removed the Stale This issue have not been touched for some time and if it doesn't change, it will be closed soon. label Dec 6, 2020
@grossmannmartin grossmannmartin removed this from the SSFW 11.0.0 milestone Apr 26, 2023
@grossmannmartin grossmannmartin changed the base branch from master to 12.0 April 26, 2023 05:51
@grossmannmartin grossmannmartin enabled auto-merge (squash) April 26, 2023 14:36
@grossmannmartin grossmannmartin merged commit e0fdaf8 into shopsys:12.0 Apr 26, 2023
9 checks passed
TomasLudvik pushed a commit that referenced this pull request May 4, 2023
@pk16011990 @TomasLudvik
[framework] encapsulation of AdditionalImageData (#1934)
b28b61e
TomasLudvik pushed a commit that referenced this pull request May 10, 2023
@pk16011990 @TomasLudvik
[framework] encapsulation of AdditionalImageData (#1934)
bf78500
TomasLudvik pushed a commit that referenced this pull request May 15, 2023
@pk16011990 @TomasLudvik
[framework] encapsulation of AdditionalImageData (#1934)
ceb3273
TomasLudvik pushed a commit that referenced this pull request Jun 14, 2023
@pk16011990 @TomasLudvik
[framework] encapsulation of AdditionalImageData (#1934)
d62aac8
TomasLudvik pushed a commit that referenced this pull request Jun 15, 2023
@pk16011990 @TomasLudvik
[framework] encapsulation of AdditionalImageData (#1934)
afef5d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasLudvik TomasLudvik TomasLudvik approved these changes

Assignees
No one assigned
Labels
DX & Refactoring Requests for DX improvements and refactorings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pk16011990 @TomasLudvik @grossmannmartin @henzigo @sslt