[shopsys] added BlankLineBeforeStatementFixer for ensuring empty line before statements #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TomasLudvik
commented
Nov 19, 2020
TomasLudvik
commented
| Q | A |
|---|---|
| Description, reason for the PR | This PR adds fixer to ensure empty line before: break, continue, declare, do, for, foreach, if, return, switch, throw, try, while and yield |
| New feature | Yes |
| BC breaks | No |
| Fixes issues | ... |
| Have you read and signed our License Agreement for contributions? | Yes |
TomasLudvik
added
the
DX & Refactoring
TomasLudvik
force-pushed
the
tl-add-empty-line-before-statements
branch
3 times, most recently
from
b32b6bb
to
9c309de
Compare
grossmannmartin
requested changes
Nov 19, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
sslt
previously approved these changes
Nov 19, 2020
sslt
dismissed
their stale review
There is rather emotional discussion, whether this is the best approach in it's current form. After the dust settles, we will continue...
TomasLudvik
force-pushed
the
tl-add-empty-line-before-statements
branch
from
cf251a5
to
b340f52
Compare
…nsuring empty lines before statements applied for: - 'break' - 'continue' - 'declare' - 'do' - 'for' - 'foreach' - 'if' - 'return' - 'switch' - 'throw' - 'try' - 'while' - 'yield'
…e\BlankLineBeforeStatementFixer
TomasLudvik
force-pushed
the
tl-add-empty-line-before-statements
branch
from
b340f52
to
81439ff
Compare
grossmannmartin
approved these changes
May 12, 2023
…e with slevomat sniffs - property per class limit sniff is not supported in any other library so it has been removed - slevomat/coding-standars has been updated to newest version - unused private elements sniff has been removed as same check is done by PHPStan
I have replaced it |
pk16011990
approved these changes
May 17, 2023
…mmenting\InlineDocCommentDeclarationSniff.InvalidFormat"
TomasLudvik
force-pushed
the
tl-add-empty-line-before-statements
branch
from
2fec059
to
c2a512d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.