Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[framework] refactoring of NormalizeUrlTrailingSlashSubscriber #2153

Merged
merged 2 commits into from Dec 17, 2020
Merged

[framework] refactoring of NormalizeUrlTrailingSlashSubscriber #2153

merged 2 commits into from Dec 17, 2020

Conversation

malyMiso
Copy link
Contributor

@malyMiso malyMiso commented Dec 7, 2020

…TrailingSlashFromString

Q A
Description, reason for the PR refactoring of NormalizeUrlTrailingSlashSubscriber
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

@malyMiso malyMiso force-pushed the mt-http-normailizer-remove-dry branch from a861f70 to 7812e86 Compare December 8, 2020 06:52
@malyMiso malyMiso force-pushed the mt-http-normailizer-remove-dry branch from 7812e86 to 4aebb2d Compare December 9, 2020 06:27
@sslt sslt added the Enhancement New feature or request for change from user point of view label Dec 11, 2020
@sslt sslt added this to the SSFW 9.1.0 milestone Dec 11, 2020
@sslt sslt changed the title refactoring of NormalizeUrlTrailingSlashSubscriber [framework] refactoring of NormalizeUrlTrailingSlashSubscriber Dec 11, 2020
Base automatically changed from mt-find-by-slug-feapi to master December 15, 2020 11:03
@malyMiso malyMiso force-pushed the mt-http-normailizer-remove-dry branch from 4aebb2d to bce03c4 Compare December 15, 2020 11:06
malyMiso added a commit that referenced this pull request Dec 15, 2020
@malyMiso
NormalizeUrlTrailingSlashSubscriber uses TransformString::addOrRemove…
0332a46 
…TrailingSlashFromString (#2153)
@malyMiso malyMiso force-pushed the mt-http-normailizer-remove-dry branch from bce03c4 to 0332a46 Compare December 15, 2020 11:09
@s3tezsky s3tezsky added the Easy Pick Not tricky or complex issue label Dec 15, 2020
s3tezsky pushed a commit that referenced this pull request Dec 15, 2020
fixup! NormalizeUrlTrailingSlashSubscriber uses TransformString::addO…
a0cd9d0 
…rRemoveTrailingSlashFromString (#2153)
@s3tezsky s3tezsky force-pushed the mt-http-normailizer-remove-dry branch from a0cd9d0 to 1c38d3d Compare December 15, 2020 15:26
@s3tezsky s3tezsky force-pushed the mt-http-normailizer-remove-dry branch from 1c38d3d to 28474cc Compare December 16, 2020 16:14
@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@s3tezsky s3tezsky merged commit 0c661fb into master Dec 17, 2020
@s3tezsky s3tezsky deleted the mt-http-normailizer-remove-dry branch December 17, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grossmannmartin grossmannmartin grossmannmartin approved these changes

@sslt sslt sslt approved these changes

Assignees
No one assigned
Labels
Easy Pick Not tricky or complex issue Enhancement New feature or request for change from user point of view
Projects
None yet
Milestone
SSFW 9.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@malyMiso @grossmannmartin @sslt @s3tezsky