[framework] changing parameter name now affects product detail #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
grossmannmartin
commented
Mar 1, 2021
grossmannmartin
commented
| Q | A |
|---|---|
| Description, reason for the PR | Parameter names are exported to elastic, so when a parameter is updated, changes have to be propagated to Elasticsearch. |
| New feature | No |
| BC breaks | No |
| Fixes issues | closes #2160 |
| Have you read and signed our License Agreement for contributions? | Yes |
s3tezsky
approved these changes
Mar 2, 2021
sslt
approved these changes
Mar 2, 2021
grossmannmartin
force-pushed
the
mg-parameter-name-change-export
branch
from
f741030
to
7e2da3e
Compare
grossmannmartin
force-pushed
the
mg-parameter-name-change-export
branch
from
7e2da3e
to
4cfbc7b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.