AdministrationFacade: support requests without _route parameter #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
grossmannmartin
force-pushed
the
mp-support-requests-without-route-parameter
branch
from
186c7df
to
40cd57e
Compare
TomasLudvik
approved these changes
May 2, 2023
pk16011990
approved these changes
May 2, 2023
grossmannmartin
force-pushed
the
mp-support-requests-without-route-parameter
branch
from
40cd57e
to
a13dc19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
render_hinclude(controller(..))in twig (from symfony documentation), no_routeparam is present on request. This fails the check inside\Shopsys\FrameworkBundle\Model\Administration\AdministrationFacade::isInAdmin.