[shopsys] replace swiftmailer with symfony/mailer #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vitek-rostislav
commented
Jun 15, 2022
vitek-rostislav
commented
| Q | A |
|---|---|
| Description, reason for the PR | Swift Mailer is not maintained anymore |
| New feature | Yes |
| BC breaks | Yes |
| Fixes issues | ... |
| Have you read and signed our License Agreement for contributions? | Yes |
vitek-rostislav
force-pushed
the
rv-fw-831-mailer
branch
2 times, most recently
from
3c3fd75
to
1fb1e57
Compare
grossmannmartin
requested changes
Jun 21, 2022
packages/framework/src/Model/Mail/EventListener/EnvelopeListener.php
Outdated
Show resolved
Hide resolved
RobinDvorak
reviewed
Jun 28, 2022
RobinDvorak
reviewed
Jun 29, 2022
- mail spooling is not available anymore, the mails are sent immediatelly now - MAILER_DELIVERY_WHITELIST and MAILER_MASTER_EMAIL_ADDRESS are not implemented yet
vitek-rostislav
force-pushed
the
rv-fw-831-mailer
branch
from
5665158
to
28e3971
Compare
- the mails are not spooled anymore - it is necessary to add verify_peer=false to DSN when using djfarrelly/maildev as smtp-server
- instead, the failure is logged - MessageData is now strictly typed to ensure all required parts are filled-in
vitek-rostislav
force-pushed
the
rv-fw-831-mailer
branch
from
58c6686
to
8d686be
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
grossmannmartin
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.