Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shopsys] resolve symfony/translations deprecations #2487

Merged
merged 9 commits into from Jul 25, 2022
Merged

[shopsys] resolve symfony/translations deprecations #2487

merged 9 commits into from Jul 25, 2022

Conversation

RobinDvorak
Copy link
Contributor

@RobinDvorak RobinDvorak commented Jul 15, 2022 •
edited

Q A
Description, reason for the PR Remove deprecations from symfony/translations
New feature No
BC breaks Yes
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

@RobinDvorak RobinDvorak changed the title translation deprecations [shopsys] resolve symfony/translations deprecations Jul 17, 2022
vitek-rostislav
vitek-rostislav requested changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@vitek-rostislav vitek-rostislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, nice job, I have just a few notes 😉

project-base/templates/Front/Inline/Cart/cartBox.html.twig Outdated Show resolved Hide resolved
project-base/templates/Front/Content/Search/autocomplete.html.twig Show resolved Hide resolved
packages/framework/tests/Unit/Component/Translation/Resources/Controller.php Show resolved Hide resolved
upgrade/UPGRADE-v11.0.0-dev.md Outdated Show resolved Hide resolved
vitek-rostislav
vitek-rostislav approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@vitek-rostislav vitek-rostislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! I have also tested it, no more translator deprecations, great!

@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.5% 5.5% Duplication

@RobinDvorak RobinDvorak merged commit a13d385 into master Jul 25, 2022
@RobinDvorak RobinDvorak deleted the rd-translation-deprecations branch July 25, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grossmannmartin grossmannmartin grossmannmartin approved these changes

@vitek-rostislav vitek-rostislav vitek-rostislav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RobinDvorak @grossmannmartin @vitek-rostislav