Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shopsys] Elasticsearch: defined structure for ID #2495

Merged
merged 1 commit into from Dec 28, 2023
Merged

[shopsys] Elasticsearch: defined structure for ID #2495

merged 1 commit into from Dec 28, 2023

Conversation

sspooky13
Copy link
Contributor

Q A
Description, reason for the PR If I understand elastic structure right, we use _id and id where _id comes from array index and id comes from classic bulk data. If my theory is correct, id has no defined structure and he should have it. I understand is little thing but I would like to see all data defined in structure, for sure. If I am wrong, you can close this PR. Thanks 馃
New feature No
BC breaks Yes
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2022

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

@pk16011990 pk16011990 added this to the 10.0.3 milestone Jul 29, 2022
@sspooky13 sspooky13 mentioned this pull request Feb 21, 2023
Merged
@pk16011990 pk16011990 removed this from the 10.0.3 milestone May 5, 2023
@grossmannmartin grossmannmartin changed the base branch from master to 14.0 December 27, 2023 08:37
@grossmannmartin grossmannmartin changed the title Elasticsearch: defined structure for ID [project-base] Elasticsearch: defined structure for ID Dec 27, 2023
@grossmannmartin grossmannmartin added the DX & Refactoring Requests for DX improvements and refactorings label Dec 27, 2023
@grossmannmartin grossmannmartin changed the title [project-base] Elasticsearch: defined structure for ID [shopsys] Elasticsearch: defined structure for ID Dec 27, 2023
@grossmannmartin grossmannmartin merged commit 682fb48 into shopsys:14.0 Dec 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pk16011990 pk16011990 pk16011990 approved these changes

@vitek-rostislav vitek-rostislav vitek-rostislav approved these changes

Assignees
No one assigned
Labels
DX & Refactoring Requests for DX improvements and refactorings In Backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sspooky13 @pk16011990 @vitek-rostislav @grossmannmartin