[framework] removed DRY violation in AggregationResultToProductFilterCountDtaTransformer and fixed property name #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sspooky13
commented
Aug 2, 2022
•
sspooky13
commented
| Q | A |
|---|---|
| Description, reason for the PR | These methods were absolutely same |
| New feature | No |
| BC breaks | Yes |
| Fixes issues | ... |
| Have you read and signed our License Agreement for contributions? | Yes |
|
Kudos, SonarCloud Quality Gate passed!
|
TomasLudvik
changed the title
TomasLudvik
changed the title
TomasLudvik
changed the title
TomasLudvik
added
the
DX & Refactoring
TomasLudvik
force-pushed
the
pt-dry
branch
2 times, most recently
from
7bf5be3
to
aca3b9b
Compare
.../framework/src/Model/Product/Search/AggregationResultToProductFilterCountDataTransformer.php
Outdated
Show resolved
Hide resolved
LuKillman
reviewed
Apr 5, 2023
.../framework/src/Model/Product/Search/AggregationResultToProductFilterCountDataTransformer.php
Show resolved
Hide resolved
packages/framework/src/Model/Product/Search/ProductFilterCountDataElasticsearchRepository.php
Show resolved
Hide resolved
TomasLudvik
force-pushed
the
pt-dry
branch
2 times, most recently
from
5727126
to
8c8bba8
Compare
LuKillman
approved these changes
Apr 11, 2023
pk16011990
approved these changes
Apr 12, 2023
…sformer and marked duplicit method for removal in next major
…for rename in next major
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.