[project-base] fix tests for product searching #2524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitek-rostislav
force-pushed
the
rv-fix-test
branch
from
89180f0
to
922e123
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
TomasLudvik
approved these changes
Jan 30, 2023
- the file is renamed to include "Test" suffix so the test is run - the category persistent references are fetched globally instead of from domain
TomasLudvik
force-pushed
the
rv-fix-test
branch
from
343e608
to
fdb3cbb
Compare
TomasLudvik
added
the
DX & Refactoring
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testsphing target because of the missing suffixBtw, when fixing the tests on my project that is based on the commerce cloud version, I had to fix a few more issues -
testSearchInAllProductsis trying to search the phrase "book" but nothing is found (the first domain has Czech locale). After changing the test search phrase to "kniha", expected products were found indeed, however, their ordering was different.