Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[framework] remove product variant urls from sitemap #2530

Merged
merged 1 commit into from Jan 17, 2023

Conversation

RostislavKreisinger
Copy link
Contributor

@RostislavKreisinger RostislavKreisinger commented Jan 4, 2023

Q A
Description, reason for the PR the sitemap now contains only the url addresses of the common product and the main product variants. Links to product variants do not have their own landing page, so they are not in the sitemap.
New feature Yes
BC breaks Yes
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

@RostislavKreisinger RostislavKreisinger changed the title remove variant product urls from sitemap remove product variant urls from sitemap Jan 4, 2023
@TomasLudvik TomasLudvik changed the title remove product variant urls from sitemap [framework] remove product variant urls from sitemap Jan 9, 2023
@TomasLudvik TomasLudvik added the Enhancement New feature or request for change from user point of view label Jan 9, 2023
@TomasLudvik TomasLudvik added this to the SSFW 11.0.0 milestone Jan 9, 2023
upgrade/UPGRADE-v11.0.0-dev.md Outdated Show resolved Hide resolved
@RostislavKreisinger RostislavKreisinger force-pushed the rk-fw-984-main-variant-url-in-sitemap branch from 2e88688 to 04637eb Compare January 9, 2023 14:04
… and the main product variants. Links to product variants do not have their own landing page, so they are not in the sitemap.
@RostislavKreisinger RostislavKreisinger force-pushed the rk-fw-984-main-variant-url-in-sitemap branch from 04637eb to 0987fe5 Compare January 17, 2023 08:21
@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RostislavKreisinger RostislavKreisinger enabled auto-merge (squash) January 17, 2023 08:24
@RostislavKreisinger RostislavKreisinger merged commit 64c9955 into master Jan 17, 2023
@RostislavKreisinger RostislavKreisinger deleted the rk-fw-984-main-variant-url-in-sitemap branch January 17, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request for change from user point of view
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants