Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[framework] New Redis Commander #2550

Merged
merged 1 commit into from Feb 3, 2023
Merged

[framework] New Redis Commander #2550

merged 1 commit into from Feb 3, 2023

Conversation

RostislavKreisinger
Copy link
Contributor

Q A
Description, reason for the PR old phpRedisAdmin has been replaced with new Redis Commander
New feature Yes
BC breaks No
Fixes issues closes #2532
Have you read and signed our License Agreement for contributions? Yes

@RostislavKreisinger RostislavKreisinger added the Infrastructure Docker, kubernetess, cloud,... label Jan 30, 2023
@RostislavKreisinger RostislavKreisinger added this to the SSFW 11.0.0 milestone Jan 30, 2023
@vitek-rostislav
Copy link
Contributor

vitek-rostislav commented Jan 30, 2023 •
edited

do not forget to update the docs please, eg. https://github.com/shopsys/shopsys/blob/master/docs/installation/installation-using-docker-application-setup.md#2-see-it-in-your-browser

TomasLudvik
TomasLudvik requested changes Feb 1, 2023
View reviewed changes
Copy link
Member

@TomasLudvik TomasLudvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update project-base/kubernetes/deployments/redis-admin.yml

docker/conf/docker-compose-mac.yml.dist Outdated Show resolved Hide resolved
@TomasLudvik TomasLudvik changed the title New Redis Commander [framework] New Redis Commander Feb 1, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RostislavKreisinger RostislavKreisinger merged commit ade436b into master Feb 3, 2023
@RostislavKreisinger RostislavKreisinger deleted the rk-fw-1074-redis-commander branch February 3, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasLudvik TomasLudvik TomasLudvik approved these changes

@pk16011990 pk16011990 pk16011990 approved these changes

Assignees
No one assigned
Labels
Infrastructure Docker, kubernetess, cloud,...
Projects
None yet
Milestone
SSFW 11.0.0
Development

Successfully merging this pull request may close these issues.

Use redis-commander instead of redis admin
4 participants
@RostislavKreisinger @vitek-rostislav @TomasLudvik @pk16011990