[framework] fixed dumping translations by adding support for translation domain constants #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TomasLudvik
commented
Feb 14, 2023
TomasLudvik
commented
| Q | A |
|---|---|
| Description, reason for the PR | In #2549 we have started using constants for translation domains, but sadly, that change was poorly tested and we broke translations dumping. This PR fixes that. |
| New feature | Yes |
| BC breaks | No |
| Fixes issues | ... |
| Have you read and signed our License Agreement for contributions? | Yes |
TomasLudvik
added
Bug
TomasLudvik
force-pushed
the
tl-fix-translations-dump
branch
from
86aa61a
to
ffa43a8
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
RostislavKreisinger
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.