[shopsys] too many attempts js error is now translated on frontend #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
grossmannmartin
commented
May 7, 2023
grossmannmartin
commented
| Q | A |
|---|---|
| Description, reason for the PR | This PR slightly reworks the #2599. Error message in ajax call is now translated directly in JS, so it's possible to dump translations. (previously it was not possible due to variable in a trans function) |
| New feature | No |
| BC breaks | No |
| Fixes issues | ... |
| Have you read and signed our License Agreement for contributions? | Yes |
TomasLudvik
approved these changes
May 9, 2023
pk16011990
reviewed
May 9, 2023
grossmannmartin
force-pushed
the
mg-fix-dump-translations
branch
from
a30f42a
to
bb61a8c
Compare
pk16011990
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.