Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shopsys] added order filter by domain in admin #2796

Merged
merged 6 commits into from Sep 21, 2023
Merged

[shopsys] added order filter by domain in admin #2796

merged 6 commits into from Sep 21, 2023

Conversation

grossmannmartin
Copy link
Member

@grossmannmartin grossmannmartin commented Sep 14, 2023 •
edited by github-actions bot

Q A
Description, reason for the PR Orders from only one domain can be displayed in admin in the order list. Refactoring of domain filter in categories and blog categories was done along.
New feature Yes
BC breaks Yes
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

馃寪 Live Preview:

@grossmannmartin grossmannmartin force-pushed the mg-order-list-domain branch 2 times, most recently from f4a0078 to 6fca73c Compare September 14, 2023 13:53
TomasLudvik
TomasLudvik approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@TomasLudvik TomasLudvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change feels like it should be documented. I leave this up to you -> approve.

pk16011990
pk16011990 requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@pk16011990 pk16011990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There exist a few removed/changed methods and deleted twig template. Shouldn't there be upgrade notes?

@grossmannmartin grossmannmartin merged commit 8bea62f into 13.0 Sep 21, 2023
16 checks passed
@grossmannmartin grossmannmartin deleted the mg-order-list-domain branch September 21, 2023 06:15
@grossmannmartin grossmannmartin added the Enhancement New feature or request for change from user point of view label Sep 22, 2023
@grossmannmartin grossmannmartin mentioned this pull request Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasLudvik TomasLudvik TomasLudvik approved these changes

@pk16011990 pk16011990 pk16011990 approved these changes

Assignees
No one assigned
Labels
Enhancement New feature or request for change from user point of view
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grossmannmartin @TomasLudvik @pk16011990