Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shopsys] elasticsearch now can have a different index setting per environment #2823

Merged
merged 1 commit into from Sep 25, 2023
Merged

[shopsys] elasticsearch now can have a different index setting per environment #2823

merged 1 commit into from Sep 25, 2023

Conversation

grossmannmartin
Copy link
Member

@grossmannmartin grossmannmartin commented Sep 21, 2023 •
edited by github-actions bot

Q A
Description, reason for the PR Elasticsearch index may need a different replicas/shard setting while running in production. Running elastic locally or on CI with multiple replicas may unnecessarily consume more resources. With this PR, the values set in the index definition JSON files will be used in production, but in development or when limitation is forced by environment variable (FORCE_ELASTIC_LIMITS) only 1 shard and 0 replicas will be used.
New feature Yes
BC breaks Yes
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

🌐 Live Preview:

@grossmannmartin grossmannmartin force-pushed the mg-allow-limit-elastic branch 2 times, most recently from ef85f32 to af9e56a Compare September 21, 2023 10:25
@grossmannmartin grossmannmartin enabled auto-merge (squash) September 25, 2023 14:48
@grossmannmartin grossmannmartin added the Infrastructure Docker, kubernetess, cloud,... label Sep 25, 2023
@grossmannmartin grossmannmartin merged commit 4ca6e69 into 13.0 Sep 25, 2023
16 checks passed
@grossmannmartin grossmannmartin deleted the mg-allow-limit-elastic branch September 25, 2023 15:05
tvikito pushed a commit that referenced this pull request Oct 4, 2023
@grossmannmartin @tvikito
[shopsys] elasticsearch now can have a different index setting per en…
066f7f2 
…vironment (#2823)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasLudvik TomasLudvik TomasLudvik approved these changes

@pk16011990 pk16011990 pk16011990 approved these changes

Assignees
No one assigned
Labels
Infrastructure Docker, kubernetess, cloud,...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grossmannmartin @TomasLudvik @pk16011990