Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shopsys] updated our LICENSE by new one for version 13.0 #2849

Merged
merged 1 commit into from Oct 6, 2023
Merged

[shopsys] updated our LICENSE by new one for version 13.0 #2849

merged 1 commit into from Oct 6, 2023
+217 −278

Conversation

TomasLudvik
Copy link
Member

@TomasLudvik TomasLudvik commented Oct 3, 2023 •
edited by github-actions bot

Q A
Description, the reason for the PR For version 13.0 we have merged the current Shopsys Framework with our Shopsys Commerce Cloud that included many new features such as JavaScript Storefront. Shopsys Commerce Cloud had a stricter LICENSE so we are introducing this LICENSE for all our public repositories currently using our proprietary LICENSE.
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

🌐 Live Preview:

@TomasLudvik TomasLudvik added the Documentation Something needs documentation or documentation is not clear or correct label Oct 3, 2023
grossmannmartin
grossmannmartin approved these changes Oct 3, 2023
View reviewed changes
LICENSE Show resolved Hide resolved
pk16011990
pk16011990 requested changes Oct 4, 2023
View reviewed changes
Copy link
Member

@pk16011990 pk16011990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to add upgrade notes to change the license in the project and at the same time it will be a warning that the license is changing.

@TomasLudvik TomasLudvik enabled auto-merge (squash) October 6, 2023 11:54
@TomasLudvik TomasLudvik merged commit 235ad80 into 13.0 Oct 6, 2023
16 checks passed
@TomasLudvik TomasLudvik deleted the tl-change-license branch October 6, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grossmannmartin grossmannmartin grossmannmartin approved these changes

@pk16011990 pk16011990 pk16011990 approved these changes

Assignees
No one assigned
Labels
Documentation Something needs documentation or documentation is not clear or correct
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TomasLudvik @grossmannmartin @pk16011990