Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[project-base] improvements of product list in grapesjs #2879

Merged
merged 5 commits into from Oct 24, 2023
Merged

[project-base] improvements of product list in grapesjs #2879

merged 5 commits into from Oct 24, 2023

Conversation

grossmannmartin
Copy link
Member

@grossmannmartin grossmannmartin commented Oct 15, 2023 •
edited by github-actions bot

Q A
Description, reason for the PR This PR improves the Product list component in GrapesJS editor. Now the rendering of products does not break if space, dash or similar character is present in the component setting. Also fixes article demo data (to prevent rendering footer twice).
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

🌐 Live Preview:

@grossmannmartin grossmannmartin changed the title catnums now may be inserted with spaces [project-base] improvements of product list in grapesjs Oct 15, 2023
@grossmannmartin grossmannmartin force-pushed the mg-improve-catnums-grapesjs branch 2 times, most recently from 30b5e33 to fa40121 Compare October 15, 2023 13:21
@TomasLudvik
Copy link
Member

Please add UPGRADE notes

@grossmannmartin grossmannmartin added the Bug Something isn't working label Oct 17, 2023
@grossmannmartin grossmannmartin force-pushed the mg-improve-catnums-grapesjs branch 2 times, most recently from 4142489 to 4c6f480 Compare October 23, 2023 13:42
@grossmannmartin grossmannmartin merged commit 4d20dbd into 14.0 Oct 24, 2023
17 checks passed
@grossmannmartin grossmannmartin deleted the mg-improve-catnums-grapesjs branch October 24, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasLudvik TomasLudvik TomasLudvik approved these changes

@pk16011990 pk16011990 pk16011990 approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grossmannmartin @TomasLudvik @pk16011990