Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FW-1879] removed unnecessary default value for domainConfig #2888

Merged
merged 2 commits into from Oct 19, 2023
Merged

[FW-1879] removed unnecessary default value for domainConfig #2888

merged 2 commits into from Oct 19, 2023

Conversation

sebaholesz
Copy link
Contributor

@sebaholesz sebaholesz commented Oct 18, 2023 •
edited by github-actions bot

Q A
Description, reason for the PR The value is now initially set to undefined, not to first-domain data. If the value is not available when used, an exception is logged (to Sentry). The value is null-assured inside the useDomainConfig hook as we know we are setting it correctly before.
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

馃寪 Live Preview:

@sebaholesz sebaholesz added Easy Pick Not tricky or complex issue DX & Refactoring Requests for DX improvements and refactorings labels Oct 18, 2023
@sebaholesz sebaholesz self-assigned this Oct 18, 2023
pk16011990
pk16011990 requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@pk16011990 pk16011990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add upgrade notes.

@sebaholesz sebaholesz force-pushed the sh-remove-default-domain-config branch from 8b3278e to 869000d Compare October 19, 2023 08:22
@sebaholesz
removed unnecessary default value for domainConfig
5e9af2f 
- the value is now initially set to undefined
- if the value is not available when used, an exception is logged
- the value is null-assured inside the useDomainConfig hook
@sebaholesz
added upgrade notes
f6c4f74
@sebaholesz sebaholesz force-pushed the sh-remove-default-domain-config branch from 869000d to f6c4f74 Compare October 19, 2023 09:42
@sebaholesz sebaholesz merged commit 221c2a4 into 14.0 Oct 19, 2023
4 of 7 checks passed
@sebaholesz sebaholesz deleted the sh-remove-default-domain-config branch October 19, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pk16011990 pk16011990 pk16011990 approved these changes

@tvikito tvikito tvikito approved these changes

Assignees

@sebaholesz sebaholesz

Labels
DX & Refactoring Requests for DX improvements and refactorings Easy Pick Not tricky or complex issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sebaholesz @pk16011990 @tvikito