[FW-1848] SEO categories with ignored filters #2891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebaholesz
added
the
Enhancement
sebaholesz
changed the base branch from
14.0
to
tv-FW-1711-add-instant-skeletons
sebaholesz
changed the base branch from
tv-FW-1711-add-instant-skeletons
to
14.0
sebaholesz
force-pushed
the
sh-seo-categories-with-ignored-filters
branch
2 times, most recently
from
df6ef3f
to
42612b8
Compare
pk16011990
requested changes
Oct 27, 2023
There was a problem hiding this comment.
It does not work properly.
- I'm on page https://sh-seo-categories-with-ignored-filters.odin.shopsys.cloud/electronics
- Choose "In Stock" filter, url is https://sh-seo-categories-with-ignored-filters.odin.shopsys.cloud/electronics?filter=%7B%22onlyInStock%22%3Atrue%7D
- Choose "Color - black" filter, url is https://sh-seo-categories-with-ignored-filters.odin.shopsys.cloud/electronics?filter=%7B%22onlyInStock%22%3Atrue%2C%22parameters%22%3A%5B%7B%22parameter%22%3A%226436fdc5-dce6-49f8-b66d-0d4c4022f2f3%22%2C%22values%22%3A%5B%221e82a495-692b-4ba1-8d5e-b062e7312729%22%5D%7D%5D%7D but it should be https://sh-seo-categories-with-ignored-filters.odin.shopsys.cloud/elektro-barva-cerna?filter=%7B%22onlyInStock%22%3Atrue%7D
And new issue is:
- I'm on page https://sh-seo-categories-with-ignored-filters.odin.shopsys.cloud/electronics
- Choose "Color - black" filter, url is https://sh-seo-categories-with-ignored-filters.odin.shopsys.cloud/electronics?filter=%7B%22parameters%22%3A%5B%7B%22parameter%22%3A%226436fdc5-dce6-49f8-b66d-0d4c4022f2f3%22%2C%22values%22%3A%5B%221e82a495-692b-4ba1-8d5e-b062e7312729%22%5D%7D%5D%7D but it should be https://sh-seo-categories-with-ignored-filters.odin.shopsys.cloud/elektro-barva-cerna
And another one:
- I'm on page https://sh-seo-categories-with-ignored-filters.odin.shopsys.cloud/elektro-barva-cerna
- I don't see selected filter "Color - black"
sebaholesz
force-pushed
the
sh-seo-categories-with-ignored-filters
branch
2 times, most recently
from
0fd80f8
to
f0fbc6e
Compare
TomasLudvik
force-pushed
the
sh-seo-categories-with-ignored-filters
branch
from
f0fbc6e
to
061480d
Compare
|
There are this problems now: First scenario
Zaznam.obrazovky.2023-11-07.v.14.10.23.movSecond scenario
Zaznam.obrazovky.2023-11-07.v.14.25.13.mov |
sebaholesz
force-pushed
the
sh-seo-categories-with-ignored-filters
branch
from
fc59f61
to
2751a1e
Compare
sebaholesz
force-pushed
the
sh-seo-categories-with-ignored-filters
branch
from
9d5364a
to
2751a1e
Compare
tvikito
approved these changes
Nov 15, 2023
sebaholesz
force-pushed
the
sh-seo-categories-with-ignored-filters
branch
from
97dc7df
to
e87d92e
Compare
tvikito
approved these changes
Nov 16, 2023
|
Now it's ok for me |
pk16011990
approved these changes
Nov 20, 2023
…er option isSelected
…s in the URL query - the need for this functionality is based on the requirement that SEO categories should ignore (be insensitive) to some filters (such as brands or availability) - to support this functionality, some common logic was extracted into helper functions (getFilterWithoutEmpty, and buildNewQueryAfterFilterChange) - getUrlQueriesWithoutDynamicPageQueries which previously also removed falsy values from query (such as undefined or null) was split into two functions, namely getUrlQueriesWithoutDynamicPageQueries which now only takes care of removing the friendly page dynamic segment and getUrlQueriesWithoutFalsyValues which removes the falsy values
…nd seoCategories - this required some additional changes, such as moving hooks from helpers/seoCategories to hooks/seoCategories, which is necessary, because it is both a bad design and also complicates the matters when writing tests as it requires additional mocking - constants were moved to config/constants to improve both how we work with constants and how we can mock them in tests - this had to be fixed in all existing tests - unit-tests.md was formatted to satisfy standards
sebaholesz
force-pushed
the
sh-seo-categories-with-ignored-filters
branch
from
e87d92e
to
603fb6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌐 Live Preview: