Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shopsys] all commands are now named via attribute #2912

Merged
merged 1 commit into from Nov 4, 2023

Conversation

grossmannmartin
Copy link
Member

@grossmannmartin grossmannmartin commented Nov 3, 2023

Q A
Description, reason for the PR set the command default name via the $defaultName is deprecated since Symfony 6.1. The recommended way to set the command name is with attribute. This PR changes all commands to the new way.
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

馃寪 Live Preview:

@grossmannmartin grossmannmartin added the DX & Refactoring Requests for DX improvements and refactorings label Nov 3, 2023
@grossmannmartin grossmannmartin enabled auto-merge (squash) November 3, 2023 15:09
@grossmannmartin grossmannmartin changed the title [shopsys]all commands are now named via attribute [shopsys] all commands are now named via attribute Nov 3, 2023
@grossmannmartin grossmannmartin merged commit 0d7d7e3 into 14.0 Nov 4, 2023
18 checks passed
@grossmannmartin grossmannmartin deleted the mg-commands-name branch November 4, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX & Refactoring Requests for DX improvements and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants