Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[framework] RedisClientFacade::contains() now throws exception when Redis is in multimode #2915

Merged
merged 1 commit into from Nov 7, 2023
Merged

[framework] RedisClientFacade::contains() now throws exception when Redis is in multimode #2915

merged 1 commit into from Nov 7, 2023

Conversation

vitek-rostislav
Copy link
Contributor

@vitek-rostislav vitek-rostislav commented Nov 7, 2023 •
edited by github-actions bot

Q A
Description, reason for the PR Phpstan check was failing (see e.g. https://github.com/shopsys/shopsys/actions/runs/6769274639/job/18395527766) - Redis::exists returns an instance of Redis when in multimode (https://redis.io/commands/multi/) which was not taken into account
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

🌐 Live Preview:

@vitek-rostislav vitek-rostislav changed the title RedisClientFacade::contains() now throws exception when Redis is in multimode [framework] RedisClientFacade::contains() now throws exception when Redis is in multimode Nov 7, 2023
@vitek-rostislav vitek-rostislav added the Bug Something isn't working label Nov 7, 2023
@vitek-rostislav vitek-rostislav enabled auto-merge (squash) November 7, 2023 13:20
@vitek-rostislav vitek-rostislav merged commit 8e3a7d5 into 14.0 Nov 7, 2023
18 checks passed
@vitek-rostislav vitek-rostislav deleted the rv-phpstan-fix branch November 7, 2023 13:33
tvikito pushed a commit that referenced this pull request Nov 7, 2023
@vitek-rostislav @tvikito
[framework] RedisClientFacade::contains() now throws exception when R…
48e47e3 
…edis is in multimode (#2915)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grossmannmartin grossmannmartin grossmannmartin approved these changes

@TomasLudvik TomasLudvik TomasLudvik approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vitek-rostislav @grossmannmartin @TomasLudvik