Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shopsys] stock and store management moved to shopsys/framework package #2918

Merged
merged 7 commits into from Nov 30, 2023
Merged

[shopsys] stock and store management moved to shopsys/framework package #2918

merged 7 commits into from Nov 30, 2023

Conversation

grossmannmartin
Copy link
Member

@grossmannmartin grossmannmartin commented Nov 10, 2023 •
edited by github-actions bot

Q A
Description, reason for the PR Stock and Store management is a crucial part of the platform, so it should be in the base package
New feature No
BC breaks Yes
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

馃寪 Live Preview:

vitek-rostislav
vitek-rostislav approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@vitek-rostislav vitek-rostislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, nice job there 馃憣 I have added just a few notes, you can pass it to tests after you address them, I do not need to see the fixes 馃槈

packages/framework/src/Controller/Admin/ClosedDayController.php Show resolved Hide resolved
packages/framework/src/Model/Store/ClosedDay/ClosedDayData.php Outdated Show resolved Hide resolved
packages/framework/src/Model/Store/OpeningHours/OpeningHoursData.php Outdated Show resolved Hide resolved
packages/framework/src/Model/Store/StoreData.php Outdated Show resolved Hide resolved
packages/framework/src/Resources/config/services.yaml Show resolved Hide resolved
@grossmannmartin grossmannmartin force-pushed the mg-move-stock-store branch 2 times, most recently from 0bb546d to 9d43497 Compare November 30, 2023 09:51
@grossmannmartin grossmannmartin merged commit f3e2c92 into 14.0 Nov 30, 2023
18 checks passed
@grossmannmartin grossmannmartin deleted the mg-move-stock-store branch November 30, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pk16011990 pk16011990 pk16011990 approved these changes

@vitek-rostislav vitek-rostislav vitek-rostislav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grossmannmartin @pk16011990 @vitek-rostislav @TomasLudvik