Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SSP-1902] removed error logging for GTM safe push #2920

Merged
merged 2 commits into from Nov 16, 2023
Merged

[SSP-1902] removed error logging for GTM safe push #2920

merged 2 commits into from Nov 16, 2023

Conversation

sebaholesz
Copy link
Contributor

@sebaholesz sebaholesz commented Nov 13, 2023 •
edited by github-actions bot

  • logging this type of error brought no business value and thus it was removed
Q A
Description, reason for the PR Logging the fact that gtmSafePushEvent was called outside of the client into Sentry as an error brought no business value. Because of that it was removed.
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

馃寪 Live Preview:

@sebaholesz
removed error logging for GTM safe push
80aa069 
- logging this type of error brought no business value and thus
it was removed
@sebaholesz sebaholesz added the Easy Pick Not tricky or complex issue label Nov 13, 2023
@sebaholesz sebaholesz self-assigned this Nov 13, 2023
@sebaholesz sebaholesz merged commit 4129905 into 14.0 Nov 16, 2023
18 checks passed
@sebaholesz sebaholesz deleted the sh-ssp-1902-remove-gtmsafepush-error-log branch November 16, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvikito tvikito tvikito approved these changes

Assignees

@sebaholesz sebaholesz

Labels
Easy Pick Not tricky or complex issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sebaholesz @tvikito