Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monorepo coding standards: ensure all packages use the same cyclomatic complexity setting #2938

Merged
merged 2 commits into from Dec 11, 2023
Merged

monorepo coding standards: ensure all packages use the same cyclomatic complexity setting #2938

merged 2 commits into from Dec 11, 2023

Conversation

vitek-rostislav
Copy link
Contributor

@vitek-rostislav vitek-rostislav commented Dec 1, 2023 •
edited by github-actions bot

Q A
Description, reason for the PR Project base less strict cyclomatic complexity setting was applied in the monorepo which led to failing build on split framework package (see https://github.com/shopsys/framework/actions/runs/7060484708/job/19220109244)
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

🌐 Live Preview:

@vitek-rostislav vitek-rostislav force-pushed the rv-ecs-fix branch 2 times, most recently from 1635591 to 948ae08 Compare December 1, 2023 16:51
@vitek-rostislav
monorepo coding standards: ensure all packages use the same cyclomati…
2489591 
…c complexity setting

- in the project-base, there is a less strict setting on purpose
- project-base ecs config is applied in monorepo ecs config with the highest priority but within the monorepo, we need to use the more strict setting (defined in the coding-standards package) so we need to redeclare the complexity setting there
@vitek-rostislav
add missing dependency to shopsys/framework package
48e3c86
@vitek-rostislav vitek-rostislav merged commit 0682ebf into 14.0 Dec 11, 2023
18 checks passed
@vitek-rostislav vitek-rostislav deleted the rv-ecs-fix branch December 11, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grossmannmartin grossmannmartin grossmannmartin approved these changes

@pk16011990 pk16011990 pk16011990 approved these changes

Assignees
No one assigned
Labels
coding standards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vitek-rostislav @grossmannmartin @pk16011990