Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[project-base] stores tests enhancements #2951

Merged
merged 5 commits into from Dec 20, 2023
Merged

[project-base] stores tests enhancements #2951

merged 5 commits into from Dec 20, 2023

Conversation

vitek-rostislav
Copy link
Contributor

@vitek-rostislav vitek-rostislav commented Dec 18, 2023 •
edited by github-actions bot

Q A
Description, reason for the PR The data-fixture-based stores' tests are not time-agnostic, i.e. they are affected by the current time of the test execution. The tests started to fail during the Christmas week as in data fixtures, the Ostrava store is open on Christmas Sunday, while the Pardubice store is closed.
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

🌐 Live Preview:

grossmannmartin
grossmannmartin approved these changes Dec 19, 2023
View reviewed changes
project-base/app/tests/FrontendApiBundle/Functional/Store/GetStoreTest.php Outdated Show resolved Hide resolved
UPGRADE-14.0.md Outdated Show resolved Hide resolved
@vitek-rostislav
GetStoreTest: add keys to data sets in openingHoursDataProvider to ma…
1a2bf4b 
…ke it more clear
@vitek-rostislav
GetStoreTest now uses graphql files instead of strings for queries
69c3e88
@vitek-rostislav
GetStoresTest now uses graphql file instead of strings for queries
faffd1b
@vitek-rostislav
stores tests: remove opening hours assertions
8cd1293 
- the opening hours are already tested separately in time-agnostic testGetStoreOpeningHours
- the data-fixture-based stores tests are not time-agnostic, i.e. they are affected by the current time of the test execution
- the tests started to fail on the Christmas week as on the Christmas Sunday, the Ostrava store is open, while the Pardubice store is closed
@vitek-rostislav
add upgrade notes
c6aec1e
@vitek-rostislav vitek-rostislav added the DX & Refactoring Requests for DX improvements and refactorings label Dec 20, 2023
@vitek-rostislav vitek-rostislav changed the title stores tests enhancements [project-base] stores tests enhancements Dec 20, 2023
@vitek-rostislav vitek-rostislav merged commit 0c08daa into 14.0 Dec 20, 2023
17 checks passed
@vitek-rostislav vitek-rostislav deleted the rv-fix-store-test branch December 20, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grossmannmartin grossmannmartin grossmannmartin approved these changes

@pk16011990 pk16011990 pk16011990 approved these changes

Assignees
No one assigned
Labels
DX & Refactoring Requests for DX improvements and refactorings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vitek-rostislav @grossmannmartin @pk16011990