Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shopsys] fixed feed generation during request #2959

Merged
merged 3 commits into from Jan 5, 2024
Merged

[shopsys] fixed feed generation during request #2959

merged 3 commits into from Jan 5, 2024

Conversation

grossmannmartin
Copy link
Member

@grossmannmartin grossmannmartin commented Dec 28, 2023 •
edited by github-actions bot

Q A
Description, reason for the PR Internal Symfony's service resetter cannot be used during the request as it clears additional classes necessary for a properly working app (profiler, stopwatch, session, ...). This PR introduces a custom service resetter that clears only classes implementing ResetInterface from Shopsys\ and App\ namespace.
New feature No
BC breaks Yes
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

馃寪 Live Preview:

@grossmannmartin
removed unnecessarily extended FeedExportFactory
439cc6c 
- underlying issue #2039 is already resolved
@grossmannmartin
utilized custom service resetter during feed generation
899bc56 
- only Shopsys and App classes can be safely reset during request
@grossmannmartin
Collector classes are no longer autowired
38c1395 
- most collector classes are used only in dev mode
@grossmannmartin grossmannmartin merged commit 33825fa into 14.0 Jan 5, 2024
17 checks passed
@grossmannmartin grossmannmartin deleted the mg-fix-feed-generation branch January 5, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasLudvik TomasLudvik TomasLudvik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grossmannmartin @TomasLudvik