remove constant.js #2969
Merged
remove constant.js #2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitek-rostislav
force-pushed
the
rv-remove-constant
branch
from
40f5adc
to
9480045
Compare
grossmannmartin
approved these changes
Jan 30, 2024
pk16011990
approved these changes
Jan 31, 2024
vitek-rostislav
force-pushed
the
rv-remove-constant
branch
from
9480045
to
3d2c77a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constant('\\App\\Model\\Advert\\AdvertPositionRegistry::CATEGORIES_ABOVE_PRODUCT_LIST')) made you feel like it is parsing the constants from PHP code but actually, you had to define the constant inconstant.js. The key could have been actually anything and it had nothing to do with the PHP constant (if the constant was removed, renamed, or changed its value in PHP, it had no impact on the constant in javascript).馃寪 Live Preview: