Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SSP-2034] improve error handling for friendly URL pages based on API status codes #2973

Merged
merged 3 commits into from Jan 9, 2024
Merged

[SSP-2034] improve error handling for friendly URL pages based on API status codes #2973

merged 3 commits into from Jan 9, 2024

Conversation

sebaholesz
Copy link
Contributor

@sebaholesz sebaholesz commented Jan 7, 2024 •
edited by github-actions bot

Q A
Description, reason for the PR We want to show a 500/404 page for friendly URL pages if the data is not available or the API throws an 500 error
New feature Yes/No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

🌐 Live Preview:

@sebaholesz sebaholesz added Enhancement New feature or request for change from user point of view Easy Pick Not tricky or complex issue Frontend API labels Jan 7, 2024
@sebaholesz sebaholesz self-assigned this Jan 7, 2024
@sebaholesz sebaholesz changed the title [SSP-2034] friendly url status codes [SSP-2034] improve error handling for friendly URL pages based on API status codes Jan 7, 2024
@sebaholesz sebaholesz force-pushed the sh-ssp-2034-friendly-url-status-codes branch 2 times, most recently from 3cbe61e to 6b79f21 Compare January 8, 2024 11:15
@sebaholesz
gql response now returns error code
34435dc 
- this was included in order to allow SF to better react to
the API returning an error
@sebaholesz
SF now throws error during SSR if a friendly URL page returns a 500 e…
50dcf11 
…rror

- additionally a handleServerSideErrorResponseForFriendlyUrls
function was added to handle friendly URL SSR
status codes from the API
@sebaholesz
added upgrade notes
ddf8f5b
@sebaholesz sebaholesz force-pushed the sh-ssp-2034-friendly-url-status-codes branch from 6b79f21 to ddf8f5b Compare January 9, 2024 10:39
@sebaholesz sebaholesz merged commit f7a0660 into 14.0 Jan 9, 2024
17 checks passed
@sebaholesz sebaholesz deleted the sh-ssp-2034-friendly-url-status-codes branch January 9, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pk16011990 pk16011990 pk16011990 approved these changes

@tvikito tvikito tvikito approved these changes

Assignees

@sebaholesz sebaholesz

Labels
Easy Pick Not tricky or complex issue Enhancement New feature or request for change from user point of view Frontend API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sebaholesz @pk16011990 @tvikito