-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move migration 20200219145345 #2975
Merged
sspooky13
merged 3 commits into
shopsys:14.0
from
stanoMilan:mso-move-migration-for-advert
Mar 26, 2024
Merged
move migration 20200219145345 #2975
sspooky13
merged 3 commits into
shopsys:14.0
from
stanoMilan:mso-move-migration-for-advert
Mar 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stanoMilan
commented
Jan 8, 2024
•
edited by vitek-rostislav
edited by vitek-rostislav
Q | A |
---|---|
Description, reason for the PR | Move migration Version 20200219145345 has wrong namespace. Entity Adverts has properties $datetimeVisibleFrom and $datetimeVisibleTo in entity on framework package. |
New feature | No |
BC breaks | No |
Fixes issues | ... |
Have you read and signed our License Agreement for contributions? | Yes |
stanoMilan
changed the title
move migration to framework package
move migration 20200219145345
Jan 8, 2024
sspooky13
force-pushed
the
mso-move-migration-for-advert
branch
3 times, most recently
from
March 18, 2024 16:29
118d57f
to
978f34c
Compare
grossmannmartin
requested changes
Mar 20, 2024
sspooky13
force-pushed
the
mso-move-migration-for-advert
branch
2 times, most recently
from
March 21, 2024 14:59
bebfc33
to
a5b6d30
Compare
grossmannmartin
approved these changes
Mar 22, 2024
vitek-rostislav
approved these changes
Mar 22, 2024
vitek-rostislav
requested changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sspooky13, could you please target this PR against 14.0 branch so the fix is available in the version v14.0
. After the merge, could you also please merge the 14.0
branch into 15.0
? 🙏
sspooky13
force-pushed
the
mso-move-migration-for-advert
branch
from
March 25, 2024 08:30
a5b6d30
to
8b69c6e
Compare
vitek-rostislav
approved these changes
Mar 25, 2024
sspooky13
force-pushed
the
mso-move-migration-for-advert
branch
from
March 26, 2024 08:33
8b69c6e
to
34e2a5a
Compare
… from php-fpm container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.