Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move migration 20200219145345 #2975

Merged
merged 3 commits into from Mar 26, 2024

Conversation

stanoMilan
Copy link
Contributor

@stanoMilan stanoMilan commented Jan 8, 2024

Q A
Description, reason for the PR Move migration Version 20200219145345 has wrong namespace. Entity Adverts has properties $datetimeVisibleFrom and $datetimeVisibleTo in entity on framework package.
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

@stanoMilan stanoMilan changed the title move migration to framework package move migration 20200219145345 Jan 8, 2024
@sspooky13 sspooky13 changed the base branch from 14.0 to 15.0 March 18, 2024 15:03
@sspooky13 sspooky13 force-pushed the mso-move-migration-for-advert branch 3 times, most recently from 118d57f to 978f34c Compare March 18, 2024 16:29
@sspooky13 sspooky13 force-pushed the mso-move-migration-for-advert branch 2 times, most recently from bebfc33 to a5b6d30 Compare March 21, 2024 14:59
Copy link
Contributor

@vitek-rostislav vitek-rostislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sspooky13, could you please target this PR against 14.0 branch so the fix is available in the version v14.0. After the merge, could you also please merge the 14.0 branch into 15.0? 🙏

@sspooky13 sspooky13 changed the base branch from 15.0 to 14.0 March 25, 2024 08:24
@sspooky13 sspooky13 changed the base branch from 14.0 to 15.0 March 25, 2024 08:27
@sspooky13 sspooky13 force-pushed the mso-move-migration-for-advert branch from a5b6d30 to 8b69c6e Compare March 25, 2024 08:30
@sspooky13 sspooky13 changed the base branch from 15.0 to 14.0 March 25, 2024 08:30
@sspooky13 sspooky13 enabled auto-merge (squash) March 26, 2024 07:39
@sspooky13 sspooky13 force-pushed the mso-move-migration-for-advert branch from 8b69c6e to 34e2a5a Compare March 26, 2024 08:33
@vitek-rostislav vitek-rostislav added the Bug Something isn't working label Mar 26, 2024
@sspooky13 sspooky13 disabled auto-merge March 26, 2024 09:18
@sspooky13 sspooky13 merged commit 91641e2 into shopsys:14.0 Mar 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants