Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SSP-2065] customer's user cart is now overwritten with the incoming cart if logged in in 3rd order step #2978

Merged
merged 3 commits into from Jan 16, 2024

Conversation

sebaholesz
Copy link
Contributor

@sebaholesz sebaholesz commented Jan 9, 2024

Q A
Description, reason for the PR Previous behaviour regarding cart merging and redirects in 3rd order step was not optimal, as we do not want to confuse the user at that stage of the order process. Instead, the cart is now overwritten, which offers a better UX.
New feature Yes
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

🌐 Live Preview:

@sebaholesz sebaholesz added Enhancement New feature or request for change from user point of view Easy Pick Not tricky or complex issue Frontend API labels Jan 9, 2024
@sebaholesz sebaholesz self-assigned this Jan 9, 2024
@sebaholesz sebaholesz force-pushed the sh-ssp-2065-order-3rd-step-login branch 2 times, most recently from 06411fd to 407aff1 Compare January 9, 2024 19:58
Copy link
Contributor

@vitek-rostislav vitek-rostislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, nice job there! Let's discuss the requested changes when you have time, please

@sebaholesz sebaholesz force-pushed the sh-ssp-2065-order-3rd-step-login branch from 084340c to ca693a1 Compare January 11, 2024 15:48
- optional parameter shouldOverwriteCustomerUserCart has been
added to LoginMutation which controls if the cart of the customer
user is going to be overwritten by the cart with the incoming UUID
… in 3rd order step

- redirecting in contact-information.tsx wa removed
- shouldOverwriteCustomerUserCart is set to true in 3rd order step
@sebaholesz sebaholesz force-pushed the sh-ssp-2065-order-3rd-step-login branch from 7683f0f to 1e94158 Compare January 16, 2024 14:26
@sebaholesz sebaholesz merged commit 08143d7 into 14.0 Jan 16, 2024
17 checks passed
@sebaholesz sebaholesz deleted the sh-ssp-2065-order-3rd-step-login branch January 16, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Pick Not tricky or complex issue Enhancement New feature or request for change from user point of view Frontend API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants