New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SSP-2065] customer's user cart is now overwritten with the incoming cart if logged in in 3rd order step #2978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebaholesz
added
Enhancement
New feature or request for change from user point of view
Easy Pick
Not tricky or complex issue
Frontend API
labels
Jan 9, 2024
sebaholesz
force-pushed
the
sh-ssp-2065-order-3rd-step-login
branch
2 times, most recently
from
January 9, 2024 19:58
06411fd
to
407aff1
Compare
vitek-rostislav
requested changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, nice job there! Let's discuss the requested changes when you have time, please
project-base/app/config/graphql/types/ModelType/Security/SecurityInput/LoginInput.types.yaml
Outdated
Show resolved
Hide resolved
project-base/app/config/graphql/types/ModelType/Security/SecurityInput/LoginInput.types.yaml
Outdated
Show resolved
Hide resolved
project-base/app/src/FrontendApi/Model/Cart/MergeCartFacade.php
Outdated
Show resolved
Hide resolved
project-base/app/tests/FrontendApiBundle/Functional/Cart/MergeCartsTest.php
Outdated
Show resolved
Hide resolved
project-base/app/tests/FrontendApiBundle/Functional/Cart/MergeCartsTest.php
Show resolved
Hide resolved
vitek-rostislav
approved these changes
Jan 11, 2024
sebaholesz
force-pushed
the
sh-ssp-2065-order-3rd-step-login
branch
from
January 11, 2024 15:48
084340c
to
ca693a1
Compare
vitek-rostislav
force-pushed
the
sh-ssp-2065-order-3rd-step-login
branch
from
January 12, 2024 13:10
ca693a1
to
38e94d5
Compare
pk16011990
approved these changes
Jan 16, 2024
sebaholesz
force-pushed
the
sh-ssp-2065-order-3rd-step-login
branch
from
January 16, 2024 13:51
38e94d5
to
7683f0f
Compare
- optional parameter shouldOverwriteCustomerUserCart has been added to LoginMutation which controls if the cart of the customer user is going to be overwritten by the cart with the incoming UUID
… in 3rd order step - redirecting in contact-information.tsx wa removed - shouldOverwriteCustomerUserCart is set to true in 3rd order step
sebaholesz
force-pushed
the
sh-ssp-2065-order-3rd-step-login
branch
from
January 16, 2024 14:26
7683f0f
to
1e94158
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Easy Pick
Not tricky or complex issue
Enhancement
New feature or request for change from user point of view
Frontend API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌐 Live Preview: