Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[coding-standards] removed disallowed PHP 4 constructor type sniff #2986

Merged
merged 1 commit into from Jan 16, 2024
Merged

[coding-standards] removed disallowed PHP 4 constructor type sniff #2986

merged 1 commit into from Jan 16, 2024

Conversation

grossmannmartin
Copy link
Member

@grossmannmartin grossmannmartin commented Jan 15, 2024 •
edited by github-actions bot

Q A
Description, reason for the PR since PHP 8, methods with the same name are not considered constructors and may be safely used
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

馃寪 Live Preview:

@grossmannmartin
removed disallowed PHP 4 constructor type sniff
079a9fb 
- since PHP 8, methods with the same name are not considered constructors and may be safely used
@grossmannmartin grossmannmartin enabled auto-merge (squash) January 16, 2024 10:43
@grossmannmartin grossmannmartin merged commit 6d66166 into 14.0 Jan 16, 2024
17 checks passed
@grossmannmartin grossmannmartin deleted the mg-old-construct branch January 16, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pk16011990 pk16011990 pk16011990 approved these changes

@vitek-rostislav vitek-rostislav vitek-rostislav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grossmannmartin @pk16011990 @vitek-rostislav