Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shopsys] moved Persoo feeds to Luigi's Box feeds #3014

Merged
merged 4 commits into from Feb 12, 2024
Merged

[shopsys] moved Persoo feeds to Luigi's Box feeds #3014

merged 4 commits into from Feb 12, 2024

Conversation

TomasLudvik
Copy link
Member

@TomasLudvik TomasLudvik commented Feb 6, 2024 •
edited by github-actions bot

Q A
Description, the reason for the PR We decided before finishing of Persoo to migrate to Luigi's Box.
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

🌐 Live Preview:

@TomasLudvik TomasLudvik added the Enhancement New feature or request for change from user point of view label Feb 6, 2024
vitek-rostislav
vitek-rostislav requested changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@vitek-rostislav vitek-rostislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, nice job there, it must have been exhausting to re-work everything 🙏
I have added a few notes so please check them out. We can discuss it personally 😉

UPGRADE-14.0.md Show resolved Hide resolved
composer.json Show resolved Hide resolved
packages/article-feed-luigis-box/src/Model/LuigisBoxArticleFeedItem.php Show resolved Hide resolved
packages/category-feed-luigis-box/src/Model/FeedItem/LuigisBoxCategoryFeedItemFacade.php Outdated Show resolved Hide resolved
packages/category-feed-luigis-box/src/Model/FeedItem/LuigisBoxCategoryFeedItemFactory.php Show resolved Hide resolved
packages/product-feed-luigis-box/src/Model/Product/LuigisBoxProductRepository.php Outdated Show resolved Hide resolved
packages/product-feed-luigis-box/src/Resources/views/feed.xml.twig Show resolved Hide resolved
packages/product-feed-luigis-box/src/Resources/views/feed.xml.twig Outdated Show resolved Hide resolved
packages/product-feed-luigis-box/src/Resources/views/feed.xml.twig Outdated Show resolved Hide resolved
packages/product-feed-luigis-box/tests/Unit/LuigisBoxFeedItemTest.php Outdated Show resolved Hide resolved
@TomasLudvik TomasLudvik force-pushed the tl-move-persoo-feeds-to-luigis-box branch 5 times, most recently from 3c2cfa6 to 0ce2f60 Compare February 8, 2024 15:55
@TomasLudvik TomasLudvik force-pushed the tl-move-persoo-feeds-to-luigis-box branch 5 times, most recently from 773f696 to 080dfd1 Compare February 9, 2024 11:59
@TomasLudvik TomasLudvik force-pushed the tl-move-persoo-feeds-to-luigis-box branch from 080dfd1 to a7e115d Compare February 12, 2024 12:08
@TomasLudvik TomasLudvik merged commit aba145b into 14.0 Feb 12, 2024
17 checks passed
@TomasLudvik TomasLudvik deleted the tl-move-persoo-feeds-to-luigis-box branch February 12, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitek-rostislav vitek-rostislav vitek-rostislav approved these changes

Assignees
No one assigned
Labels
Enhancement New feature or request for change from user point of view
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TomasLudvik @vitek-rostislav